London | 26-SDC-Mar | Khilola Rustamova| Sprint 4 |Prep exercise#541
Open
HilolaRustam wants to merge 10 commits into
Open
London | 26-SDC-Mar | Khilola Rustamova| Sprint 4 |Prep exercise#541HilolaRustam wants to merge 10 commits into
HilolaRustam wants to merge 10 commits into
Conversation
HilolaRustam
added
📅 Sprint 4
LonMcGregor
reviewed
Jul 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good work on these tasks, there are a few bits where you could improve or where explanations are missing
| @@ -0,0 +1,11 @@ | |||
| def double(number): | |||
Contributor
There was a problem hiding this comment.
Can you add some mypy annotations to resolve the error?
|
|
||
|
|
||
|
|
||
| def is_adult(self): |
Contributor
There was a problem hiding this comment.
Can you describe the difference between method/function? When might one be better than the other?
|
|
||
| try: | ||
| age = int(age_input) | ||
| except ValueError: |
Contributor
There was a problem hiding this comment.
If the age is invalid, is there a way to resolve this without exiting the program early?
Same comment for the preferred OS.
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Completed the prep exercise of sprint 4 of Module-Tools.
Questions